[ 
https://issues.apache.org/jira/browse/HADOOP-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996920#comment-12996920
 ] 

Hadoop QA commented on HADOOP-6221:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12468404/HADOOP-6221.patch
  against trunk revision 1071364.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: 
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/288//testReport/
Findbugs warnings: 
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/288//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/288//console

This message is automatically generated.

> Make it possible to interrupt RPC Client operations
> ---------------------------------------------------
>
>                 Key: HADOOP-6221
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6221
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: ipc
>    Affects Versions: 0.21.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-6221.patch, HADOOP-6221.patch, HADOOP-6221.patch, 
> HADOOP-6221.patch, HADOOP-6221.patch
>
>
> RPC.waitForProxy swallows any attempts to interrupt it while waiting for a 
> proxy; this makes it hard to shutdown a service that you are starting; you 
> have to wait for the timeouts. 
> There are only 4-5 places in the code that use either of the two overloaded 
> methods, removing the catch and changing the signature should not be too 
> painful, unless anyone is using the method outside the hadoop codebase. 

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to