[
https://issues.apache.org/jira/browse/HADOOP-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998113#comment-12998113
]
Hadoop QA commented on HADOOP-7151:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12471457/HADOOP-7151.patch
against trunk revision 1071364.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/293//console
This message is automatically generated.
> Document need for stable hashCode() in WritableComparable
> ---------------------------------------------------------
>
> Key: HADOOP-7151
> URL: https://issues.apache.org/jira/browse/HADOOP-7151
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Dmitriy V. Ryaboy
> Assignee: Dmitriy V. Ryaboy
> Priority: Minor
> Attachments: HADOOP-7151.patch
>
>
> When a Writable is used as a key, HashPartitioner implicitly assumes that
> hashCode() will return the same value across different instances of the JVM.
> This is not a guaranteed behavior in Java, and Object's default hashCode()
> does not in fact do this, which can lead to subtle bugs. This requirement
> should be explicitly called out.
> In addition the sample MyWritable in the javadoc for WritableComparable does
> not implement hashCode() and thus has a bug. That should be fixed.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
