[ 
https://issues.apache.org/jira/browse/HADOOP-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013280#comment-16013280
 ] 

Yongjun Zhang commented on HADOOP-14407:
----------------------------------------

Hi [~omkarksa],

The patch looks good, except a few cosmetic things.

- The patch failed to apply. Try using "git diff --no-prefix HEAD~ " to 
generate the patch.
- some trailing white spaces, use "git apply --whitespace fix" to remove.
- DistCpOptions.java, line exceeding 80 chars

Thanks.



> DistCp - Introduce a configurable copy buffer size
> --------------------------------------------------
>
>                 Key: HADOOP-14407
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14407
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: tools/distcp
>    Affects Versions: 2.9.0
>            Reporter: Omkar Aradhya K S
>            Assignee: Omkar Aradhya K S
>             Fix For: 2.9.0, 3.0.0-alpha3
>
>         Attachments: HADOOP-14407.001.patch
>
>
> Currently, the RetriableFileCopyCommand has a fixed copy buffer size of just 
> 8KB. We have noticed in our performance tests that with bigger buffer sizes 
> we saw upto ~3x performance boost. Hence, making the copy buffer size a 
> configurable setting via the new parameter <copybuffersize>.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to