[
https://issues.apache.org/jira/browse/HADOOP-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Bokor updated HADOOP-14414:
----------------------------------
Attachment: missingFiles
Uploading [^missingFiles]. It's a diff between pre- and post-patch state of
files.
It shows only dependency-analysis.html, index.html, project-reports.html, and
the html files that generated from md files are affected.
These files are not necessary during docs generation. They are also generated
at site phrase and part of the web site.
Sidenote: is {{dependency-analysis.html}} used by anyone at all?
> Calling maven-site-plugin directly for docs profile is unnecessary
> ------------------------------------------------------------------
>
> Key: HADOOP-14414
> URL: https://issues.apache.org/jira/browse/HADOOP-14414
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Andras Bokor
> Assignee: Andras Bokor
> Priority: Minor
> Attachments: HADOOP-14414.01.patch, HADOOP-14414.02.patch,
> missingFiles
>
>
> For a few modules:
> * hadoop-auth
> * hadoop-kms
> * hadoop-hdfs-httpfs
> * hadoop-sls
> we call {{mave-site-plugin}} directly when docs profile is active.
> In main pom we use {{excludeDefaults}} in reporting section and allow only
> javadoc and dependency-plugin for the report. Since javadoc plugin is set to
> {{inherited}} false it won't be called on individual child modules. So
> actually {{maven-dependency-plugin:analyze-report}} is the only additional
> goal which will run.
> I debugged the process with {{mvn clean package -DskipTests
> -Dmaven.javadoc.skip=true -DskipShade -Pdocs -X}} command and in all the 4
> affected modules I found the following configuration for site plugin:
> {code}<reportPlugins>
> <reportPlugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-dependency-plugin</artifactId>
> <version>2.10</version>
> <reportSets>
> <reportSet>
> <id>default</id>
> <reports>
> <report>analyze-report</report>
> </reports>
> </reportSet>
> </reportSets>
> </reportPlugin>
> </reportPlugins>{code}
> At this point I do not see the purpose of calling {{mave-site-plugin}} for
> docs profile. It does not contain useful information. Or if it does why don't
> we call for other modules? It's inconsistent.
> Considering to remove.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
