[ 
https://issues.apache.org/jira/browse/HADOOP-14407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022643#comment-16022643
 ] 

Omkar Aradhya K S edited comment on HADOOP-14407 at 5/24/17 10:06 AM:
----------------------------------------------------------------------

[~yzhangal] Thanks for pointing this out! I have couple of doubts:
1. My tests are present in 
"/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestOptionsParser.java" 
--> testToString(), testParseCopyBufferSize().
2. The 
"/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpOptions.java 
--> " doesn't have "blocksPerChunk=0" so how was it passing earlier?
3. Why are there 2 redundant "testToString()" in 2 different classes?
4. Can I re-open this issue and add the patch here itself?
5. What is the procedure to test branch-2 patches? I see a "-1" from Hadoop QA 
for the branch-2 patch above!





was (Author: omkarksa):
[~yzhangal] Thanks for pointing this out! I have couple of doubts:
1. The 
"/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpOptions.java" 
doesn't have "blocksPerChunk=0" so how was it passing earlier?
2. Can I re-open this issue and add the patch here itself?
3. What is the procedure to test branch-2 patches? I see a "-1" from Hadoop QA 
for the branch-2 patch above!



> DistCp - Introduce a configurable copy buffer size
> --------------------------------------------------
>
>                 Key: HADOOP-14407
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14407
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: tools/distcp
>    Affects Versions: 2.9.0
>            Reporter: Omkar Aradhya K S
>            Assignee: Omkar Aradhya K S
>             Fix For: 2.9.0, 3.0.0-alpha3
>
>         Attachments: HADOOP-14407.001.patch, HADOOP-14407.002.patch, 
> HADOOP-14407.002.patch, HADOOP-14407.003.patch, 
> HADOOP-14407.004.branch2.patch, HADOOP-14407.004.patch, 
> HADOOP-14407.004.patch, TotalTime-vs-CopyBufferSize.jpg
>
>
> Currently, the RetriableFileCopyCommand has a fixed copy buffer size of just 
> 8KB. We have noticed in our performance tests that with bigger buffer sizes 
> we saw upto ~3x performance boost. Hence, making the copy buffer size a 
> configurable setting via the new parameter <copybuffersize>.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to