[
https://issues.apache.org/jira/browse/HADOOP-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027083#comment-16027083
]
Hongyuan Li edited comment on HADOOP-14429 at 5/31/17 9:49 AM:
---------------------------------------------------------------
[[email protected]], [~brahmareddy] [~yzhangal] Could you give me a code
review ? Seen the details of findbugs, i found one related to my change code
class, but it does not match the code i submit, no matter in patch 002 or patch
003.
was (Author: hongyuan li):
[[email protected]], [~brahmareddy] [~yzhangal] Could you give me a code
review ? Seen the details of findbugs, i found one related to my change code
class, but it does not match the code i submit no matter patch 002 or patch
003.
> getFsAction method of FTPFileSystem always return FsAction.NONE
> ----------------------------------------------------------------
>
> Key: HADOOP-14429
> URL: https://issues.apache.org/jira/browse/HADOOP-14429
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.0-alpha2
> Reporter: Hongyuan Li
> Assignee: Hongyuan Li
> Priority: Trivial
> Attachments: HADOOP-14429-001.patch, HADOOP-14429-002.patch,
> HADOOP-14429-003.patch
>
>
>
> {code}
> private FsAction getFsAction(int accessGroup, FTPFile ftpFile) {
> FsAction action = FsAction.NONE;
> if (ftpFile.hasPermission(accessGroup, FTPFile.READ_PERMISSION)) {
> action.or(FsAction.READ);
> }
> if (ftpFile.hasPermission(accessGroup, FTPFile.WRITE_PERMISSION)) {
> action.or(FsAction.WRITE);
> }
> if (ftpFile.hasPermission(accessGroup, FTPFile.EXECUTE_PERMISSION)) {
> action.or(FsAction.EXECUTE);
> }
> return action;
> }
> {code}
> from code above, we can see that the getFsAction method doesnot modify the
> action generated by FsAction action = FsAction.NONE,which means it return
> FsAction.NONE all the time;
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
