[ 
https://issues.apache.org/jira/browse/HADOOP-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031333#comment-16031333
 ] 

Steve Loughran commented on HADOOP-14422:
-----------------------------------------

I don't want to do anything which encourages anyone to insert secrets into 
URIs. Now, FTP isn't wire secure anyway, but even so, it leads to contamination 
of logs, error  messages, they even end up in exception stack traces filed in 
JIRAs.

If the problem is per-endpoint customusation, then the proposed new ftp client 
must support per-endpoint confi, as s3a does. And not support inline secrets.

> FTPFileSystem and distcp does not work when ecnountered a complex ftp 
> password with char ':' or '@'
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-14422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14422
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, tools/distcp
>    Affects Versions: 3.0.0-alpha2
>            Reporter: Hongyuan Li
>            Assignee: Hongyuan Li
>         Attachments: HADOOP-14422-002.patch, HADOOP-14422-003.patch, 
> HADOOP-14422-004.patch, HADOOP-14422-005.patch, HADOOP-14422.patch
>
>
> ftp username: test passwd:1@123
> hadoop distcp ftp://test:1@123@node2/home/test/  hdfs://piaopiao/test
> 17/05/15 15:24:56 INFO tools.DistCp: Input Options: 
> DistCpOptions{atomicCommit=false, syncFolder=false, deleteMissing=false, 
> ignoreFailures=false, maxMaps=20, sslConfigurationFile='null', 
> copyStrategy='uniformsize', sourceFileListing=null, 
> sourcePaths=[ftp://test:1@123@node2/home/test], targetPath=/test, 
> targetPathExists=true, preserveRawXattrs=false, filtersFile='null'}
> 17/05/15 15:24:57 INFO client.ConfiguredRMFailoverProxyProvider: Failing over 
> to rm2
> 17/05/15 15:24:59 ERROR tools.DistCp: Exception encountered 
> java.io.IOException: Login failed on server - 0.0.0.0, port - 21 as user 
> 'null'
>       at 
> org.apache.hadoop.fs.ftp.FTPFileSystem.connect(FTPFileSystem.java:154)
>       at 
> org.apache.hadoop.fs.ftp.FTPFileSystem.getFileStatus(FTPFileSystem.java:415)
>       at org.apache.hadoop.fs.Globber.getFileStatus(Globber.java:68)
>       at org.apache.hadoop.fs.Globber.glob(Globber.java:263)
>       at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:1630)
>       at 
> org.apache.hadoop.tools.GlobbedCopyListing.doBuildListing(GlobbedCopyListing.java:77)
>       at org.apache.hadoop.tools.CopyListing.buildListing(CopyListing.java:86)
>       at 
> org.apache.hadoop.tools.DistCp.createInputFileListing(DistCp.java:389)
>       at org.apache.hadoop.tools.DistCp.createAndSubmitJob(DistCp.java:187)
>       at org.apache.hadoop.tools.DistCp.execute(DistCp.java:153)
>       at org.apache.hadoop.tools.DistCp.run(DistCp.java:126)
>       at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>       at org.apache.hadoop.tools.DistCp.main(DistCp.java:453)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to