[ 
https://issues.apache.org/jira/browse/HADOOP-14475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038864#comment-16038864
 ] 

Yonger commented on HADOOP-14475:
---------------------------------

Thanks for your suggestion. I will take case for code style and do test by 
myself before submitting.

And answer your questions:
1. the name change of context just for distinguish with other attributes, such 
as MetricsRegistry and Metrics name. From the following log, it shows using 
different names is better than ones with the same name:
17/06/05 20:32:54 DEBUG impl.MetricsSinkAdapter: Pushing record 
S3AFileSystemMetrics.s3a.s3afilesystem to file
is it?

2.after i make a collection the relationship of those classes, i also think the 
functions of class S3AFileSystemMetricsSystem can be merge into some existed 
class, maybe S3AFileSystem.

3.that is the issue confused me. I still don't know why the 
filesystem(S3AFileSystem) be initialized multiple times in a MR job. From 
AzureFileSystem and DataNodeMetric, their filesystem and MetricSystem should be 
only initialized once.




> Metrics of S3A don't print out  when enable it in Hadoop metrics property file
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-14475
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14475
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 2.8.0
>         Environment: uname -a
> Linux client01 4.4.0-74-generic #95-Ubuntu SMP Wed Apr 12 09:50:34 UTC 2017 
> x86_64 x86_64 x86_64 GNU/Linux
>  cat /etc/issue
> Ubuntu 16.04.2 LTS \n \l
>            Reporter: Yonger
>         Attachments: s3a-metrics.patch1
>
>
> *.sink.file.class=org.apache.hadoop.metrics2.sink.FileSink
> #*.sink.file.class=org.apache.hadoop.metrics2.sink.influxdb.InfluxdbSink
> #*.sink.influxdb.url=http:/xxxxxxxxxx
> #*.sink.influxdb.influxdb_port=8086
> #*.sink.influxdb.database=hadoop
> #*.sink.influxdb.influxdb_username=hadoop
> #*.sink.influxdb.influxdb_password=hadoop
> #*.sink.ingluxdb.cluster=c1
> *.period=10
> #namenode.sink.influxdb.class=org.apache.hadoop.metrics2.sink.influxdb.InfluxdbSink
> #S3AFileSystem.sink.influxdb.class=org.apache.hadoop.metrics2.sink.influxdb.InfluxdbSink
> S3AFileSystem.sink.file.filename=s3afilesystem-metrics.out
> I can't find the out put file even i run a MR job which should be used s3.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to