[ 
https://issues.apache.org/jira/browse/HADOOP-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041511#comment-16041511
 ] 

Yongjun Zhang commented on HADOOP-13854:
----------------------------------------

Hi [~xiaochen],

Thanks for working on this. i took a look, only one comment:

Can we do the exception warn log unconditionally instead of just when doAudit 
is true? or if there is any concern?

Thanks.



> KMS should log error details even if a request is malformed
> -----------------------------------------------------------
>
>                 Key: HADOOP-13854
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13854
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: kms
>    Affects Versions: 2.6.5
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>         Attachments: HADOOP-13854.01.patch, HADOOP-13854.02.patch
>
>
> It appears if a KMS HTTP request is malformed, it could rejected by tomcat 
> and a response is sent by 
> [KMSExceptionsProvider|https://github.com/apache/hadoop/blob/branch-3.0.0-alpha1/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSExceptionsProvider.java#L99]
>  overriding Jersey's ExceptionMapper.
> This behavior is okay, but in the logs we'll see an ERROR audit log, but 
> nothing in kms.log (or anywhere else). This makes trouble shooting pretty 
> painful, let's improve it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to