[
https://issues.apache.org/jira/browse/HADOOP-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003835#comment-13003835
]
Todd Lipcon commented on HADOOP-7115:
-------------------------------------
A few comments:
- getUIDforFDOwnerforOwner is a kind of messy name - maybe just
getUIDForFDOwner?
- The following should probably be debug level:
{code}
LOG.info("Got UserName " + user + " for UID " + uid + " from the native
implementation");
{code}
- ensureInitialized has a formatting issue (cacheTimeout is on the same line as
the opening if)
- The log message there should also probably be debug level
- Do we need fstat and the Stat type at all now? I think not, we might as well
remove it.
- The change in getGroup.c seems unrelated to this JIRA, right?
> Add a cache for getpwuid_r and getpwgid_r calls
> -----------------------------------------------
>
> Key: HADOOP-7115
> URL: https://issues.apache.org/jira/browse/HADOOP-7115
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.22.0
> Reporter: Arun C Murthy
> Assignee: Devaraj Das
> Attachments: h-7115.1.patch
>
>
> As discussed in HADOOP-6978, a cache helps a lot.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
