[ 
https://issues.apache.org/jira/browse/HADOOP-14465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042541#comment-16042541
 ] 

Steve Loughran commented on HADOOP-14465:
-----------------------------------------

Minor details; I don't know enough about LDAP to actually cover the core 
functionality

{{LdapGroupsMapping}}

* use {{getTrimmed()}} to strip off whitespace.
* how about logging @ debug the values (line 602+), now that resolution is more 
complex
* you need a "." at the end of your javadoc comments: Java 8 javadoc complains 
otherwise.

{{GroupsMapping.md}}: use ` ` quotes around configuration keys in the docs to 
have them fixed font.

{{TestLdapGroupsMapping}}: can you (somehow) add a regression test which 
verifies that if only {{BASE_DN_KEY}} is set, that still gets picked up. 
There's no test working with that option as far as my IDE can tell.


> LdapGroupsMapping - support user and group search base
> ------------------------------------------------------
>
>                 Key: HADOOP-14465
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14465
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common
>            Reporter: Shwetha G S
>            Assignee: Shwetha G S
>         Attachments: 
> 0001-HADOOP-14465-LdapGroupsMapping-support-user-and-grou.patch, 
> HADOOP-14465-v2.patch
>
>
> org.apache.hadoop.security.LdapGroupsMapping currently supports 
> hadoop.security.group.mapping.ldap.base as search base for both user and 
> group searches. However, this doesn't work when user and group search bases 
> are different like ou=Users,dc=xxx,dc=com and ou=Groups,dc=xxx,dc=com. 
> Expose different configs for user and group search base which defaults to the 
> existing hadoop.security.group.mapping.ldap.base config



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to