[ 
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16045169#comment-16045169
 ] 

Junping Du commented on HADOOP-14284:
-------------------------------------

bq. If a user wants Guava out of the classpath for the client side, why not 
just use the shaded client?
I think we are working towards this direction. My understanding is YARN/MR 
client haven't finish shade practice. Isn't it?

bq. In either of those approaches folks are still out of luck on the server 
side. I thought that was the point of this jira?
There shouldn't be too much concern on server side as application will have 
separated classloader so different version of guava should get loaded for 
different places. IMO, this JIRA approach is hardly being accepted not only 
because its own complexity but also open a painful practice for other 
dependencies being upgrade with incompatible APIs.

bq. If we're only concerned about client side impact, then we should just 
upgrade guava and close this jira. 
We can not simply upgrade guava before shaded yarn/mr client works done. 
Otherwise, downstream projects will get stuck. Do I miss anything here?

> Shade Guava everywhere
> ----------------------
>
>                 Key: HADOOP-14284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14284
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Andrew Wang
>            Assignee: Tsuyoshi Ozawa
>            Priority: Blocker
>         Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, 
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch, 
> HADOOP-14284.012.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts. 
> Unfortunately, these projects also consume our private artifacts like 
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced 
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams. 
> This isn't a requirement for all dependency upgrades, but it's necessary for 
> known-bad dependencies like Guava.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to