[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048566#comment-16048566
]
Rushabh S Shah commented on HADOOP-14521:
-----------------------------------------
bq. We can either update the message, or update the maxNumRetries to
providers.length to make sure we try at least once on all providers. Either way
feels okay to me.
I wouldn't worry much about the error message not being entirely accurate.
If the user is making the number of retries less than the number of providers
then he/she knows the problems associated with it.
{quote}
Slightly prefer the latter since by assumption all providers should work and we
don't have retry delay for the whole sweep.
{quote}
Actually I don't prefer overriding the config value which user intentionally
overrode it.
If you strongly feel about updating the log message, then I can change the log
message in the next revision and will add the numRetries and providers length.
Let me know you thoughts.
[~xiaochen]: As always thanks a lot for your time reviewing all the updated
patches.
> KMS client needs retry logic
> ----------------------------
>
> Key: HADOOP-14521
> URL: https://issues.apache.org/jira/browse/HADOOP-14521
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Attachments: HDFS-11804-trunk-1.patch, HDFS-11804-trunk-2.patch,
> HDFS-11804-trunk-3.patch, HDFS-11804-trunk-4.patch, HDFS-11804-trunk-5.patch,
> HDFS-11804-trunk-6.patch, HDFS-11804-trunk-7.patch, HDFS-11804-trunk.patch
>
>
> The kms client appears to have no retry logic – at all. It's completely
> decoupled from the ipc retry logic. This has major impacts if the KMS is
> unreachable for any reason, including but not limited to network connection
> issues, timeouts, the +restart during an upgrade+.
> This has some major ramifications:
> # Jobs may fail to submit, although oozie resubmit logic should mask it
> # Non-oozie launchers may experience higher rates if they do not already have
> retry logic.
> # Tasks reading EZ files will fail, probably be masked by framework reattempts
> # EZ file creation fails after creating a 0-length file – client receives
> EDEK in the create response, then fails when decrypting the EDEK
> # Bulk hadoop fs copies, and maybe distcp, will prematurely fail
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
