[
https://issues.apache.org/jira/browse/HADOOP-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049894#comment-16049894
]
Hongyuan Li edited comment on HADOOP-14429 at 6/15/17 1:35 AM:
---------------------------------------------------------------
ok, i will try [1]it.thanks for your advice.
was (Author: hongyuan li):
ok, i will try [1]it.thanks for your advice?
在 "Yongjun Zhang (JIRA)" <j...@apache.org>，2017年6月15日 上午9:08写道：
[
[2]https://issues.apache.org/jira/browse/HADOOP-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049873#comment-16049873
]
Yongjun Zhang commented on HADOOP-[3]14429:
----------------------------------------
HI [~Hongyuan Li],
Thanks for the updated patch, and sorry for getting back late.
Another thought to share, I'm not trying to be picky, but just trying to make
it interesting programming, looks like that we could formulate an input
array/list, and run all tests in a loop, so to avoid redundant code. Would you
be interested in giving it a try? Thanks.
--
This message was sent by Atlassian JIRA
(v[24]6.4.14#64029)
----------------------------------------------------------------------------------------
[1] http://it.thanks
[2]
https://issues.apache.org/jira/browse/HADOOP-14429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049873#comment-16049873
[3] tel:14429
[4] http://FsAction.NONE
[5] tel:14429
[6] https://issues.apache.org/jira/browse/HADOOP-14429
[7] http://HADOOP-14429-001.patch
[8] http://HADOOP-14429-002.patch
[9] http://HADOOP-14429-003.patch
[10] http://HADOOP-14429-004.patch
[11] http://HADOOP-14429-005.patch
[12] http://FsAction.NONE
[13] http://ftpFile.hasPermission
[14] http://action.or
[15] http://FsAction.READ
[16] http://ftpFile.hasPermission
[17] http://action.or
[18] http://FsAction.WRITE
[19] http://ftpFile.hasPermission
[20] http://action.or
[21] http://FsAction.EXECUTE
[22] http://FsAction.NONE
[23] http://FsAction.NONE
[24] tel:641464029
> FTPFileSystem#getFsAction always returns FsAction.NONE
> -------------------------------------------------------
>
> Key: HADOOP-14429
> URL: https://issues.apache.org/jira/browse/HADOOP-14429
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.0-alpha2
> Reporter: Hongyuan Li
> Assignee: Hongyuan Li
> Attachments: HADOOP-14429-001.patch, HADOOP-14429-002.patch,
> HADOOP-14429-003.patch, HADOOP-14429-004.patch, HADOOP-14429-005.patch
>
>
>
> {code}
> private FsAction getFsAction(int accessGroup, FTPFile ftpFile) {
> FsAction action = FsAction.NONE;
> if (ftpFile.hasPermission(accessGroup, FTPFile.READ_PERMISSION)) {
> action.or(FsAction.READ);
> }
> if (ftpFile.hasPermission(accessGroup, FTPFile.WRITE_PERMISSION)) {
> action.or(FsAction.WRITE);
> }
> if (ftpFile.hasPermission(accessGroup, FTPFile.EXECUTE_PERMISSION)) {
> action.or(FsAction.EXECUTE);
> }
> return action;
> }
> {code}
> from code above, we can see that the getFsAction method doesnot modify the
> action generated by FsAction action = FsAction.NONE,which means it return
> FsAction.NONE all the time;
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
