[ https://issues.apache.org/jira/browse/HADOOP-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16052151#comment-16052151 ]
Hudson commented on HADOOP-14524: --------------------------------- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11875 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/11875/]) HADOOP-14524. Make CryptoCodec Closeable so it can be cleaned up (xiao: rev 4ebc23ba7b16c7b9acf38b5a864682a6c8890690) * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoCodec.java * (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/crypto/TestCryptoStreamsWithOpensslAesCtrCryptoCodec.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/KeyProviderCryptoExtension.java * (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/DataTransferSaslUtil.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/OpensslAesCtrCryptoCodec.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/AesCtrCryptoCodec.java * (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/CryptoUtils.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoOutputStream.java * (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/CryptoInputStream.java > Make CryptoCodec Closeable so it can be cleaned up proactively > -------------------------------------------------------------- > > Key: HADOOP-14524 > URL: https://issues.apache.org/jira/browse/HADOOP-14524 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Xiao Chen > Assignee: Xiao Chen > Fix For: 2.9.0, 3.0.0-alpha4 > > Attachments: HADOOP-14524.01.patch, HADOOP-14524.branch-2.01.patch > > > See HADOOP-14523 for motivation. Credit to [~mi...@cloudera.com] for > reporting initially there. > Basically, the {{CryptoCodec}} class is not a closeable, but the > {{OpensslAesCtrCryptoCodec}} implementation of it contains a closeable member > (the Random object). Currently it is left for {{finalize()}} to clean up, > this depends on when a FGC is run, and would create problems if > {{OpensslAesCtrCryptoCodec}} is used with {{OsSecureRandom}}, which could let > OS run out of FDs on {{/dev/urandom}} if too many codecs created. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org