[ 
https://issues.apache.org/jira/browse/HADOOP-14423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063580#comment-16063580
 ] 

Hadoop QA commented on HADOOP-14423:
------------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 16m 
54s{color} | {color:red} root in HADOOP-13345 failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
7s{color} | {color:red} hadoop-aws in HADOOP-13345 failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
14s{color} | {color:green} HADOOP-13345 passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m  
7s{color} | {color:red} hadoop-aws in HADOOP-13345 failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m  
7s{color} | {color:red} hadoop-aws in HADOOP-13345 failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m  
8s{color} | {color:red} hadoop-aws in HADOOP-13345 failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m  
6s{color} | {color:red} hadoop-aws in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red}  0m  
5s{color} | {color:red} hadoop-aws in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red}  0m  5s{color} 
| {color:red} hadoop-aws in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
11s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} mvnsite {color} | {color:red}  0m  
6s{color} | {color:red} hadoop-aws in the patch failed. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m  
5s{color} | {color:red} hadoop-aws in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red}  0m  
7s{color} | {color:red} hadoop-aws in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}  0m  5s{color} 
| {color:red} hadoop-aws in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
17s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 57s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |  Image:yetus/hadoop:14b5c93 |
| JIRA Issue | HADOOP-14423 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12874533/HADOOP-14423-HADOOP-13345-001.patch
 |
| Optional Tests |  asflicense  compile  javac  javadoc  mvninstall  mvnsite  
unit  findbugs  checkstyle  |
| uname | Linux d5a42cfb6e8e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh 
|
| git revision | HADOOP-13345 / 2b3c4b8 |
| Default Java | 1.8.0_131 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/branch-mvninstall-root.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/branch-compile-hadoop-tools_hadoop-aws.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/branch-mvnsite-hadoop-tools_hadoop-aws.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/branch-findbugs-hadoop-tools_hadoop-aws.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/branch-javadoc-hadoop-tools_hadoop-aws.txt
 |
| mvninstall | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/patch-mvninstall-hadoop-tools_hadoop-aws.txt
 |
| compile | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-aws.txt
 |
| javac | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/patch-compile-hadoop-tools_hadoop-aws.txt
 |
| mvnsite | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/patch-mvnsite-hadoop-tools_hadoop-aws.txt
 |
| findbugs | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/patch-findbugs-hadoop-tools_hadoop-aws.txt
 |
| javadoc | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/patch-javadoc-hadoop-tools_hadoop-aws.txt
 |
| unit | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-aws.txt
 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/testReport/ |
| modules | C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws |
| Console output | 
https://builds.apache.org/job/PreCommit-HADOOP-Build/12627/console |
| Powered by | Apache Yetus 0.5.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> s3guard will set file length to -1 on a putObjectDirect(stream, -1) call
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-14423
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14423
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Minor
>         Attachments: HADOOP-14423-HADOOP-13345-001.patch
>
>
> You can pass a negative number into {{S3AFileSystem.putObjectDirect}}, which 
> means "put until the end of the stream". S3guard has been using this {{len}} 
> argument: it needs to be using the actual number of bytes uploaded. Also 
> relevant with client side encryption, when the amount of data put > the 
> amount of data in the file or stream.
> Noted in the committer branch after I added some more assertions, I've 
> changed it there so making changes to S3AFS.putObjectDirect to pull the 
> content length to pass in to finishedWrite() from the {{PutObjectResult}} 
> instead. This can be picked into the s3guard branch



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to