[ 
https://issues.apache.org/jira/browse/HADOOP-14599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068807#comment-16068807
 ] 

Daryn Sharp commented on HADOOP-14599:
--------------------------------------

The ipc layer has engines to handle both protobufs and writables so it's not 
safe to cast to a protobuf.

What would really be nice:
# split the queue and processing time updates
# float the queue time update up to when the call is extracted from the queue 
in {{Handler#run}} – avoids updating both engines
# update the processing time in the finally

> RPC queue time metrics omit timed out clients
> ---------------------------------------------
>
>                 Key: HADOOP-14599
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14599
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: metrics, rpc-server
>    Affects Versions: 2.7.0
>            Reporter: Ashwin Ramesh
>            Assignee: Ashwin Ramesh
>         Attachments: HADOOP-14599.001.patch
>
>
> RPC average queue time metrics will now update even if the client who made 
> the call timed out while the call was in the call queue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to