[ https://issues.apache.org/jira/browse/HADOOP-7175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006681#comment-13006681 ]
Hadoop QA commented on HADOOP-7175: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12473427/HADOOP-7175-2.patch against trunk revision 1080817. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/309//console This message is automatically generated. > Add isEnabled() to Trash > ------------------------ > > Key: HADOOP-7175 > URL: https://issues.apache.org/jira/browse/HADOOP-7175 > Project: Hadoop Common > Issue Type: Bug > Components: fs > Reporter: Daryn Sharp > Assignee: Daryn Sharp > Fix For: 0.23.0 > > Attachments: HADOOP-7175-2.patch, HADOOP-7175.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The moveToTrash method returns false in a number of cases. It's not possible > to discern if false means an error occurred. In particular, it's not possible > to know if the trash is disabled vs. an error occurred. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira