[ https://issues.apache.org/jira/browse/HADOOP-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079108#comment-16079108 ]
Hongyuan Li commented on HADOOP-14623: -------------------------------------- none of the test failure is related with this patch. None checkstyle warning and findbug warning. > fixed some bugs in KafkaSink > ----------------------------- > > Key: HADOOP-14623 > URL: https://issues.apache.org/jira/browse/HADOOP-14623 > Project: Hadoop Common > Issue Type: Bug > Components: common, tools > Affects Versions: 3.0.0-alpha3 > Reporter: Hongyuan Li > Assignee: Hongyuan Li > Attachments: HADOOP-14623-001.patch, HADOOP-14623-002.patch > > > {{KafkaSink}}#{{init}} should set ack to *1* to make sure the message has > been written to the broker at least. > current code list below: > {code} > > props.put("request.required.acks", "0"); > {code} > *Update* > find another bug about this class, {{key.serializer}} used > {{org.apache.kafka.common.serialization.ByteArraySerializer}}, however, the > key properties of Producer is Integer, codes list below: > {code} > props.put("key.serializer", > "org.apache.kafka.common.serialization.ByteArraySerializer"); > …………… > producer = new KafkaProducer<Integer, byte[]>(props); > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org