[
https://issues.apache.org/jira/browse/HADOOP-14103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Zhuge updated HADOOP-14103:
--------------------------------
Attachment: HADOOP-14103.002.patch
Patch 002
* Fix checkstyle
* Update "ftp" section in filesystem/testing.md
[~steve_l] Can we not check in contract-test-options.xml? It does not seem to
add a lot of value. The file is simple enough to create on the fly based on the
template in doc.
Also if XInclude auth-keys.xml is added to "s3a.xml",
"contract-test-options.xml" is no longer needed. Property
{{fs.contract.test.fs.s3a}} can be added to "auth-keys.xml", just as
{{test.fs.s3a.name}}. Although the test properties in "auth-keys.xml" do feel
awkward.
> Sort out hadoop-aws contract-test-options.xml
> ---------------------------------------------
>
> Key: HADOOP-14103
> URL: https://issues.apache.org/jira/browse/HADOOP-14103
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: 2.8.0
> Reporter: Steve Loughran
> Assignee: John Zhuge
> Priority: Minor
> Attachments: HADOOP-14103.001.patch, HADOOP-14103.002.patch
>
>
> The doc update of HADOOP-14099 has shown that there's confusion about whether
> we need a src/test/resources/contract-test-options.xml file.
> It's documented as needed, branch-2 has it in .gitignore; trunk doesn't.
> I think it's needed for the contract tests, which the S3A test base extends
> (And therefore needs). However, we can just put in an SCM managed one and
> have it just XInclude auth-keys.xml
> I propose: do that, fix up the testing docs to match
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
