[
https://issues.apache.org/jira/browse/HADOOP-14683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100637#comment-16100637
]
Gopal V edited comment on HADOOP-14683 at 7/25/17 7:50 PM:
-----------------------------------------------------------
bq. does this retain the binary search functionality?
Yes - that's why I suggested it.
Also for ABI compat, it means that any existing code compiled with call-site
compareTo(FileStatus) will continue to work, without breaking ABI from 2.8.0 ->
2.8.2.
(edit: just realized for some calls, result will now be an Object, not
FileStatus - needs a cast, to assign)
As you said it used to handle non-FileStatus objects previously as not-equal.
was (Author: gopalv):
bq. does this retain the binary search functionality?
Yes - that's why I suggested it.
Also for ABI compat, it means that any existing code compiled with call-site
compareTo(FileStatus) will continue to work, without breaking ABI from 2.8.0 ->
2.8.2.
(edit: just realized binarySearch() result will now be an Object, not
FileStatus - needs a cast, to assign)
As you said it used to handle non-FileStatus objects previously as not-equal.
> FileStatus.compareTo binary compat issue between 2.7 and 2.8
> ------------------------------------------------------------
>
> Key: HADOOP-14683
> URL: https://issues.apache.org/jira/browse/HADOOP-14683
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.8.0, 2.8.1
> Reporter: Sergey Shelukhin
> Assignee: Akira Ajisaka
> Priority: Blocker
> Attachments: HADOOP-14683-branch-2-01.patch
>
>
> See HIVE-17133. Looks like the signature change is causing issues; according
> to [~jnp] this is a public API.
> Is it possible to add the old overload back (keeping the new one presumably)
> in a point release on 2.8? That way we can avoid creating yet another shim
> for this in Hive.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
