[
https://issues.apache.org/jira/browse/HADOOP-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13011411#comment-13011411
]
Tsz Wo (Nicholas), SZE commented on HADOOP-7194:
------------------------------------------------
Good catch! It seems that closing in the finally-block using
{{closeStream(..)}} is sufficient. The following is not required.
{code}
if(close) {
out.close();
+ out = null;
in.close();
+ in = null;
}
{code}
> Potential Resource leak in IOUtils.java
> ---------------------------------------
>
> Key: HADOOP-7194
> URL: https://issues.apache.org/jira/browse/HADOOP-7194
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Attachments: HADOOP-7194.patch
>
>
> {code:title=IOUtils.java|borderStyle=solid}
> try {
> copyBytes(in, out, buffSize);
> } finally {
> if(close) {
> out.close();
> in.close();
> }
> }
> {code}
> In the above code if any exception throws from the out.close() statement,
> in.close() statement will not execute and the input stream will not be closed.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira