[ 
https://issues.apache.org/jira/browse/HADOOP-14680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108608#comment-16108608
 ] 

Steve Loughran commented on HADOOP-14680:
-----------------------------------------

its a bit moot now the patch is in, but please be aware that the error message 
raised when assertEquals fails only makes sense if the constant/expected value 
is the first arg, not the second. That is {{assertEquals(numBytesReadV1, 
KILOBYTE)}} should have been {{assertEquals( KILOBYTE, numBytesReadV1)}}. It 
doesn't merit a patch here, but its something to remember in future. thanks

> Azure: IndexOutOfBoundsException in BlockBlobInputStream
> --------------------------------------------------------
>
>                 Key: HADOOP-14680
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14680
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/azure
>            Reporter: Rajesh Balamohan
>            Assignee: Thomas Marquardt
>            Priority: Minor
>             Fix For: 3.0.0-beta1
>
>         Attachments: HADOOP-14680-001.patch, HADOOP-14680-branch-2.01.patch
>
>
> https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azure/BlockBlobInputStream.java#L361
> On certain conditions, BlockBlobInputStream can throw 
> IndexOutOfBoundsException. Following is an example
> {{length:297898, offset:4194304, buf.len:4492202, writePos:4194304}} : 
> In this case, {{MemoryOutputStream::capacity()}} would end up returning 
> negative value and can cause {{IndexOutOfBoundsException}}
> It should be {{return buffer.length - offset;}} to determine current capacity.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to