[
https://issues.apache.org/jira/browse/HADOOP-14498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Mackrory updated HADOOP-14498:
-----------------------------------
Attachment: HADOOP-14498.001.patch
Now that HADOOP-13595 is in I had a look at this. It is indeed the regex
matching logic in hadoop_add_param being overzealous. That function does
already state an assumption that it is space-delimited, so I used spaces or
line boundaries to ensure a full-word patch instead of just a partial one.
Rather than have it use arrays, let's fix this function for all the other
places it's used instead of using something from HADOOP-13595 instead.
Attaching a patch. I got a clean Yetus run locally, but it wasn't running bats
tests for some reason. I ran the hadoop_add_param tests manually but not the
others, and some unrelated Java test failures seem to be blocking it (unless
there's a way to bypass that and easily run all bats tests?)
> HADOOP_OPTIONAL_TOOLS not parsed correctly
> ------------------------------------------
>
> Key: HADOOP-14498
> URL: https://issues.apache.org/jira/browse/HADOOP-14498
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Affects Versions: 3.0.0-alpha1
> Reporter: Mingliang Liu
> Assignee: Sean Mackrory
> Priority: Critical
> Attachments: HADOOP-14498.001.patch
>
>
> # This will make hadoop-azure not show up in the hadoop classpath, though
> both hadoop-aws and hadoop-azure-datalake are in the
> classpath.{code:title=hadoop-env.sh}
> export HADOOP_OPTIONAL_TOOLS="hadoop-azure,hadoop-aws,hadoop-azure-datalake"
> {code}
> # And if we put only hadoop-azure and hadoop-aws, both of them are shown in
> the classpath.
> {code:title=hadoop-env.sh}
> export HADOOP_OPTIONAL_TOOLS="hadoop-azure,hadoop-aws"
> {code}
> This makes me guess that, while parsing the {{HADOOP_OPTIONAL_TOOLS}}, we
> make some assumptions that hadoop tool modules have a single "-" in names,
> and the _hadoop-azure-datalake_ overrides the _hadoop-azure_. Or any other
> assumptions about the {{${project.artifactId\}}}?
> Ping [~aw].
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
