[ 
https://issues.apache.org/jira/browse/HADOOP-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115122#comment-16115122
 ] 

Chris Douglas commented on HADOOP-14726:
----------------------------------------

FWIW, not making {{isDir}} final would not break compilation, but it would 
cause infinite recursion in FileSystem implementations that override 
{{isDirectory}} to call {{isDir}}, but {{isDir}} calls {{super.isDir}}, 
{{isDir}} is not overridden, etc.

Personally, I'd lean toward making {{isDir}} final to cause compilation 
failures instead of this class of bugs for FileSystem implementations. But I'll 
go with the prevailing taste consensus.

> Remove FileStatus#isDir
> -----------------------
>
>                 Key: HADOOP-14726
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14726
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: HADOOP-14726.000.patch, HADOOP-14726.001.patch
>
>
> FileStatus#isDir was deprecated in 0.21 (HADOOP-6585).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to