[ 
https://issues.apache.org/jira/browse/HADOOP-14722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Marquardt updated HADOOP-14722:
--------------------------------------
    Attachment: HADOOP-14722-006.patch

Attaching HADOOP-14722-006.patch.

Thanks for the feedback Steve!  I took your 005 patch and 1) added additional 
comments, 2) updated *BlockBlobInputStream.seek()* so the offset is positive 
for forward seek and negative for reverse seek, 3) changed the test name 
*BasicReadTestV2* to *BasicReadTest* since it validates  V1 and V2 are 
identical, and 4) changed the access modifier of 
*TestBlockBlobInputStream.verifyConsistentReads()* from protected to private.

I reviewed the de-duplication change you made to test_0201_RandomReadTest and 
it looks perfect.

All hadoop-tools/hadoop-azure *tests are passing* against my tmarql3 storage 
account.  I set "fs.azure.secure.mode" to false due to the HADOOP-14715 issue 
we are still working on.  Here are the test results:

*Tests run: 774, Failures: 0, Errors: 0, Skipped: 155*

> Azure: BlockBlobInputStream position incorrect after seek
> ---------------------------------------------------------
>
>                 Key: HADOOP-14722
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14722
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/azure
>            Reporter: Thomas Marquardt
>            Assignee: Thomas Marquardt
>         Attachments: HADOOP-14722-001.patch, HADOOP-14722-002.patch, 
> HADOOP-14722-003.patch, HADOOP-14722-005.patch, HADOOP-14722-006.patch
>
>
> The seek, skip, and getPos methods of BlockBlobInputStream do not correctly 
> account for the stream's  internal buffer.  This results in invalid stream 
> positions. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to