[
https://issues.apache.org/jira/browse/HADOOP-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117527#comment-16117527
]
Subru Krishnan commented on HADOOP-14741:
-----------------------------------------
Thanks [~goiri] for working on this. I am fine with merging the configurations
as:
* I feel *strongly* that we already have way too many config knobs already.
* From what I have observed in production deployments, RMs and NNs are deployed
on different physical machines so they could still have different values (i.e.
role based configuration). Additionally, even in same machines you can set the
hadoop confs per process.
Regarding the patch itself, I just have a few minor comments:
* {{CuratorManager}} --> {{ZKCuratorManager}} (or {{CuratorZKManager}}).
* The keys should be defined in {{CommonConfigurationKeys}} so that they can be
overridden via _core-site.xml_.
* Can you add *exists* check before and after we do an op in the tests.
* Nit: some public methods are missing Javadocs.
> Refactor curator based ZooKeeper communication into common library
> ------------------------------------------------------------------
>
> Key: HADOOP-14741
> URL: https://issues.apache.org/jira/browse/HADOOP-14741
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Subru Krishnan
> Assignee: Íñigo Goiri
> Attachments: HADOOP-14741-000.patch
>
>
> Currently we have ZooKeeper based store implementations for multiple state
> stores like RM, YARN Federation, HDFS router-based federation, RM queue
> configs etc. This jira proposes to unify the curator based ZK communication
> to eliminate redundancies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
