[
https://issues.apache.org/jira/browse/HADOOP-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117597#comment-16117597
]
Wei-Chiu Chuang commented on HADOOP-14743:
------------------------------------------
Attach patch rev 001. This patch prints a warning message, and a more detailed
stacktrace is printed at debug log level.
After this patch, the CompositeGroupsMapping would record the following log:
{noformat}
2017-08-07 17:05:31,696 WARN security.CompositeGroupsMapping
(CompositeGroupsMapping.java:getGroups(77)) - Unable to get groups for user
Jack via UserProvider because: java.io.IOException: foo
2017-08-07 17:05:31,708 DEBUG security.CompositeGroupsMapping
(CompositeGroupsMapping.java:getGroups(79)) - Stacktrace:
java.io.IOException: foo
at
org.apache.hadoop.security.TestCompositeGroupMapping$UserProvider.getGroups(TestCompositeGroupMapping.java:120)
at
org.apache.hadoop.security.CompositeGroupsMapping.getGroups(CompositeGroupsMapping.java:75)
at
org.apache.hadoop.security.Groups$GroupCacheLoader.fetchGroupList(Groups.java:384)
at
org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:319)
at
org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:269)
at
com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3568)
at
com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2350)
at
com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2313)
at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2228)
at com.google.common.cache.LocalCache.get(LocalCache.java:3965)
at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3969)
at
com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4829)
at org.apache.hadoop.security.Groups.getGroups(Groups.java:227)
{noformat}
> CompositeGroupsMapping should not swallow exceptions
> ----------------------------------------------------
>
> Key: HADOOP-14743
> URL: https://issues.apache.org/jira/browse/HADOOP-14743
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Attachments: HADOOP-14743.001.patch
>
>
> {code:title=CompositeGroupsMapping#getGroups}
> for (GroupMappingServiceProvider provider : providersList) {
> try {
> groups = provider.getGroups(user);
> } catch (Exception e) {
> //LOG.warn("Exception trying to get groups for user " + user, e);
>
> }
> if (groups != null && ! groups.isEmpty()) {
> groupSet.addAll(groups);
> if (!combined) break;
> }
> }
> {code}
> If anything fails inside the underlying groups mapping service provider,
> there's no way to tell what went wrong.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
