Steve Loughran updated HADOOP-14749:
    Attachment: HADOOP-14749-HADOOP-13345-002.patch

Patch 002; sync with s3guard after the various patch-pending patches went in. 
Essentially: less to review.

While looking at the diff, I'm now worried about the high-ascii chars in the 
illustration in {{TestDynamoDBMetadataStore.verifyRootDirectory()}}. It's a 
lovely diagram, and I had to look at it to see how it was done —which is with 
chars > 0x80. I don't know how well this works in different locale; I do know 
we can't use other high ascii symbols, eg. "—" without encoding to &mdash. (I 
say that, but a quick scan for "—" shows lots of uses in hadoop-aws, and I 
probably the guilty party. We should perhaps fix that.

> review s3guard docs & code prior to merge
> -----------------------------------------
>                 Key: HADOOP-14749
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14749
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: documentation, fs/s3
>    Affects Versions: HADOOP-13345
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: HADOOP-14749-HADOOP-13345-001.patch, 
> HADOOP-14749-HADOOP-13345-002.patch
>   Original Estimate: 24h
>  Remaining Estimate: 24h
> Pre-merge cleanup while it's still easy to do
> * Read through all the docs, tune
> * Diff the trunk/branch files to see if we can reduce the delta (and hence 
> the changes)
> * Review the new tests

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to