[ 
https://issues.apache.org/jira/browse/HADOOP-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andras Bokor updated HADOOP-14526:
----------------------------------
    Description: 
If exception X is thrown in try block, and exception Y is thrown is finally 
block, X will be swallowed. 

In addition, finally block is used to ensure resources are released properly in 
general. If we throw exception from there, some resources may be leaked. So 
it's not recommended to throw exception in the finally block

I caught one today and reported HDFS-11974, creating this jira as a master one 
to catch other similar cases.

Hope there is some static analyzer to find all.


  was:
If exception X is thrown in try block, and exception Y is thrown is finally 
block, X will be swallowed. 

In addition, finally block is used to ensure resources are released properly in 
general. If we throw exception from there, some resources may be leaked. So 
it's not recommended to throw exception in the finally block

I caught one today and reported HDFS-11794, creating this jira as a master one 
to catch other similar cases.

Hope there is some static analyzer to find all.



> Examine code base for cases that exception is thrown from finally block
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-14526
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14526
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Yongjun Zhang
>
> If exception X is thrown in try block, and exception Y is thrown is finally 
> block, X will be swallowed. 
> In addition, finally block is used to ensure resources are released properly 
> in general. If we throw exception from there, some resources may be leaked. 
> So it's not recommended to throw exception in the finally block
> I caught one today and reported HDFS-11974, creating this jira as a master 
> one to catch other similar cases.
> Hope there is some static analyzer to find all.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to