[
https://issues.apache.org/jira/browse/HADOOP-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124495#comment-16124495
]
John Zhuge commented on HADOOP-14703:
-------------------------------------
+1 LGTM with a nit. It is better to create test directories/files inside
{{target}} directory. You can use {{GenericTestUtils.getTestDir()}} which
returns a created base test directory.
{code:java}
this.configFile = new File(GenericTestUtils.getTestDir(),
String.format("hadoop-metrics2-%s.properties", TEST_PREFIX));
{code}
> ConsoleSink for metrics2
> ------------------------
>
> Key: HADOOP-14703
> URL: https://issues.apache.org/jira/browse/HADOOP-14703
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, metrics
> Affects Versions: 3.0.0-beta1
> Reporter: Ronald Macmaster
> Assignee: Ronald Macmaster
> Labels: newbie
> Attachments:
> 0001-HADOOP-14703.-ConsoleSink-for-simple-metrics-printin.patch,
> HADOOP-14703.001.patch, HADOOP-14703.002.patch
>
> Original Estimate: 6h
> Remaining Estimate: 6h
>
> The ConsoleSink will provide a simple solution to dump metrics to the console
> through std.out.
> Quick access to metrics through the console will simplify the development,
> testing, and debugging process.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
