[
https://issues.apache.org/jira/browse/HADOOP-14777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129101#comment-16129101
]
Aaron Fabbri commented on HADOOP-14777:
---------------------------------------
{quote}
One more thought: should we change the policy at the top of the testing.md doc
to say
submitters MUST declare their s3guard settings in test runs (even if not
enabled)
submitters SHOULD test with: s3guard ddb/localddb as well as no s3guard, &
declare outcomes.
submitters SHOULD declare any encryption endpoints used
{quote}
Yes I think we should address it in testing.md.
Running tests with LocalMetadataStore (i.e. just specifying -Ds3guard alone) is
important to make sure folks don't break S3Guard logic. LocalDDB solves the
same problem I suppose: allowing people to test without having to provision and
pay for a realy DynamoDB table.
We could either (A) Make w/ and w/o -Ds3guard a MUST, or (B) play it by ear,
saying "Submitters MUST test with and without -Ds3guard if their change may
affect S3Guard". The latter is difficult to interpret, but at least sets
expectations.
> S3Guard premerge changes: java 7 build & test tuning
> ----------------------------------------------------
>
> Key: HADOOP-14777
> URL: https://issues.apache.org/jira/browse/HADOOP-14777
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3, test
> Affects Versions: HADOOP-13345
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Minor
> Attachments: HADOOP-14777-HADOOP-13345-001.patch
>
>
> Another set of changes for S3Guard in preparation for merging via HADOOP-13998
> * checkstyle issues
> * Made Java 7 friendly (indeed, tested applied to branch-2 with some POM
> changes & tested there)
> * improve diagnostics on some test failure. This would address HADOOP-14750.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
