[ 
https://issues.apache.org/jira/browse/HADOOP-14779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129298#comment-16129298
 ] 

Xiao Chen commented on HADOOP-14779:
------------------------------------

bq. we don't have to checkin this code and then revert once that is done.
Thanks for the concern Rushabh.

This jira is specifically targeted for a refactor to the current 
{{decryptEncryptedKey}}, to separate out the 'parse the passed in 
{{EncryptedKeyVersion encryptedKeyVersion}} var' logic and the 'decrypt that 
and return a new {{KeyVersion}} logic, so I think serves a separate goal.

This refactor would still be the same when we move the codec object to be a 
member var. For that task, all other methods should also be inspected and 
changed. Created HADOOP-14780 for that.

> Refactor decryptEncryptedKey in KeyProviderCryptoExtension
> ----------------------------------------------------------
>
>                 Key: HADOOP-14779
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14779
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: kms
>    Affects Versions: 2.6.0
>            Reporter: Xiao Chen
>            Assignee: Xiao Chen
>            Priority: Minor
>         Attachments: HADOOP-14779.01.patch
>
>
> We could separate out the actual decrypt logic from the 
> {{decryptEncryptedKey}}. This enables reencrypt calls to possibly reuse the 
> codec.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to