[ 
https://issues.apache.org/jira/browse/HADOOP-14284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16129648#comment-16129648
 ] 

Haibo Chen edited comment on HADOOP-14284 at 8/17/17 12:03 AM:
---------------------------------------------------------------

Shading the whole code base also makes more sense for hadoop IMO, given the 
fact that, as [~andrew.wang] pointed out in the comment above, downstream 
projects still depend on hadoop-hdfs, which is a server module. In YARN-7028 
and YARN-6414, we also discovered that the guava version that hbase-client 
depends on can conflict with the guava version that hadoop uses, shading server 
modules (hbase-client is embedded in NM and RM) will help avoid that issue.


was (Author: haibochen):
Shading the whole code base also makes more sense for hadoop IMO, given the 
fact that, as [~andrew.wang] pointed out in the comment above, downstream 
projects still depend on hadoop-hdfs, which is a server module. In YARN-7028, 
we also discovered that the guava version that hbase-client depends on can 
conflict with the guava version that hadoop uses, shading server modules 
(hbase-client is embedded in NM and RM) will help avoid that issue.

> Shade Guava everywhere
> ----------------------
>
>                 Key: HADOOP-14284
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14284
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Andrew Wang
>            Assignee: Tsuyoshi Ozawa
>            Priority: Blocker
>         Attachments: HADOOP-14238.pre001.patch, HADOOP-14284.002.patch, 
> HADOOP-14284.004.patch, HADOOP-14284.007.patch, HADOOP-14284.010.patch, 
> HADOOP-14284.012.patch
>
>
> HADOOP-10101 upgraded the guava version for 3.x to 21.
> Guava is broadly used by Java projects that consume our artifacts. 
> Unfortunately, these projects also consume our private artifacts like 
> {{hadoop-hdfs}}. They also are unlikely on the new shaded client introduced 
> by HADOOP-11804, currently only available in 3.0.0-alpha2.
> We should shade Guava everywhere to proactively avoid breaking downstreams. 
> This isn't a requirement for all dependency upgrades, but it's necessary for 
> known-bad dependencies like Guava.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to