[
https://issues.apache.org/jira/browse/HADOOP-14705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133358#comment-16133358
]
Xiao Chen edited comment on HADOOP-14705 at 8/18/17 5:55 PM:
-------------------------------------------------------------
Thanks [~jojochuang] for the careful reviews.
bq. warnings
I tried your suggestions (just #1, add <String, String> and remove the
SupressWarning).
Recompiling, I see (and do not see these with patch 8):
{noformat}
[WARNING]
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java:
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
uses unchecked or unsafe operations.
[WARNING]
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java:
Recompile with -Xlint:unchecked for details.
[WARNING]
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java:
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java
uses unchecked or unsafe operations.
[WARNING]
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java:
Recompile with -Xlint:unchecked for details.
{noformat}
I agree in general fixing warning is better than suppressing. But here it feels
to me an overkill to wrack a mole on all existing usages to remove the
annotation. Also, this patch only tries to move the helper methods to a utility
class - the annotations exists even before.
bq. CryptoCodec...
Good question and discussions.
Since that impacts generate only, and it's not being changed here, shall we
continue on HADOOP-14780? Pasted above comments on that one.
was (Author: xiaochen):
Thanks [~jojochuang] for the careful reviews.
re. warnings
I tried your suggestions (just #1, add <String, String> and remove the
SupressWarning).
Recompiling, I see (and do not see these with patch 8):
{noformat}
[WARNING]
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java:
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
uses unchecked or unsafe operations.
[WARNING]
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java:
Recompile with -Xlint:unchecked for details.
[WARNING]
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java:
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java
uses unchecked or unsafe operations.
[WARNING]
/Users/xiao/Desktop/repo/hdfs/xiao/hadoop/hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java:
Recompile with -Xlint:unchecked for details.
{noformat}
I agree in general fixing warning is better than suppressing. But here it feels
to me an overkill to wrack a mole on all existing usages to remove the
annotation. Also, this patch only tries to move the helper methods to a utility
class - the annotations exists even before.
bq. CryptoCodec...
Good question and discussions.
Since that impacts generate only, and it's not being changed here, shall we
continue on HADOOP-14780? Pasted above comments on that one.
> Add batched reencryptEncryptedKey interface to KMS
> --------------------------------------------------
>
> Key: HADOOP-14705
> URL: https://issues.apache.org/jira/browse/HADOOP-14705
> Project: Hadoop Common
> Issue Type: Improvement
> Components: kms
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HADOOP-14705.01.patch, HADOOP-14705.02.patch,
> HADOOP-14705.03.patch, HADOOP-14705.04.patch, HADOOP-14705.05.patch,
> HADOOP-14705.06.patch, HADOOP-14705.07.patch, HADOOP-14705.08.patch
>
>
> HADOOP-13827 already enabled the KMS to re-encrypt a {{EncryptedKeyVersion}}.
> As the performance results of HDFS-10899 turns out, communication overhead
> with the KMS occupies the majority of the time. So this jira proposes to add
> a batched interface to re-encrypt multiple EDEKs in 1 call.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
