[
https://issues.apache.org/jira/browse/HADOOP-14820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147860#comment-16147860
]
Thomas Marquardt commented on HADOOP-14820:
-------------------------------------------
Looks good. I have the following feedback:
*NativeAzureFileSystem.java*
*L1714* - When the file already exists and overwrite is true, both
{{performAuthCheck}} calls (L1700 and L1714) are checking permissions on the
file. The {{performAuthCheck}} on L1714 can be removed.
*L2426* - The method {{getAncestor}} no longer returns the ancestor or parent
path; instead, it returns the first path segment that exists. I recommend
renaming it
{{getFirstPathSegmentThatExists}}.
*L2459* - The {{ancestor}} field is actual the first path segment that exists,
which may be the file itself. method {{getAncestor}} no longer returns the
ancestor or parent path; instead, it returns the first path segment that
exists. I recommend renaming it {{firstExistingPathSegment}}.
.
> Fix for HDFS semantics parity for mkdirs -p
> --------------------------------------------
>
> Key: HADOOP-14820
> URL: https://issues.apache.org/jira/browse/HADOOP-14820
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Reporter: Sivaguru Sankaridurg
> Assignee: Sivaguru Sankaridurg
> Labels: azure, fs, secure, wasb
> Attachments: HADOOP-14820.001.patch, HADOOP-14820.002.patch
>
>
> No authorization checks should be made when a user tries to create (mkdirs
> -p) an existing folder hierarchy.
> For example, if we start with _/home/hdiuser/prefix_ pre-created, and do the
> following operations, the results should be as shown below.
> {noformat}
> hdiuser@hn0-0d2f67:~$ sudo chown root:root prefix
> hdiuser@hn0-0d2f67:~$ sudo chmod 555 prefix
> hdiuser@hn0-0d2f67:~$ ls -l
> dr-xr-xr-x 3 root root 4096 Aug 29 08:25 prefix
> hdiuser@hn0-0d2f67:~$ mkdir -p /home
> hdiuser@hn0-0d2f67:~$ mkdir -p /home/hdiuser
> hdiuser@hn0-0d2f67:~$ mkdir -p /home/hdiuser/prefix
> hdiuser@hn0-0d2f67:~$ mkdir -p /home/hdiuser/prefix/1
> mkdir: cannot create directory â/home/hdiuser/prefix/1â: Permission denied
> The first three mkdirs succeed, because the ancestor is already present. The
> fourth one fails because of a permission check against the (shorter) ancestor
> (as compared to the path being created).
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
