[
https://issues.apache.org/jira/browse/HADOOP-14850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158500#comment-16158500
]
Hadoop QA commented on HADOOP-14850:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m
12s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 15m
52s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
53s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} hadoop-common-project/hadoop-common: The patch
generated 0 new + 52 unchanged - 2 fixed = 52 total (was 54) {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
40s{color} | {color:red} hadoop-common-project/hadoop-common generated 1 new +
0 unchanged - 0 fixed = 1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 9m 47s{color}
| {color:red} hadoop-common in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
33s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 4s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-common-project/hadoop-common |
| | Redundant nullcheck of resourceUrl, which is known to be non-null in
org.apache.hadoop.http.HttpServer2.getWebAppsPath(String) Redundant null check
at HttpServer2.java:is known to be non-null in
org.apache.hadoop.http.HttpServer2.getWebAppsPath(String) Redundant null check
at HttpServer2.java:[line 1012] |
| Failed junit tests | hadoop.http.TestGlobalFilter |
| | hadoop.http.TestPathFilter |
| | hadoop.http.TestHttpServer |
| | hadoop.fs.sftp.TestSFTPFileSystem |
| | hadoop.http.TestSSLHttpServer |
| | hadoop.http.TestServletFilter |
| | hadoop.http.TestHttpServerLogs |
| | hadoop.http.TestAuthenticationSessionCookie |
| | hadoop.security.TestKDiag |
| | hadoop.http.TestHttpServerWebapps |
| | hadoop.http.TestHttpServerWithSpengo |
| | hadoop.http.TestHttpCookieFlag |
| | hadoop.http.TestHttpServerLifecycle |
| | hadoop.jmx.TestJMXJsonServlet |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | HADOOP-14850 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12886038/HADOOP-14850.002.patch
|
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite
unit findbugs checkstyle |
| uname | Linux 986b878e7838 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh
|
| git revision | trunk / b3a4d7d |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| findbugs |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13207/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-common.html
|
| unit |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13207/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13207/testReport/ |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/13207/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Read HttpServer2 resources directly from the source tree (if exists)
> --------------------------------------------------------------------
>
> Key: HADOOP-14850
> URL: https://issues.apache.org/jira/browse/HADOOP-14850
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0-alpha4
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Attachments: HADOOP-14850.001.patch, HADOOP-14850.002.patch
>
>
> Currently the Hadoop server components can't be started from IDE during the
> development. There are two reasons for that:
> 1. some artifacts are in provided scope which are definitelly needed to run
> the server (see HDFS-12197)
> 2. The src/main/webapp dir should be on the classpath (but not).
> In this issue I suggest to fix the second issue by reading the web resources
> (html and css files) directly from the source tree and not from the classpath
> but ONLY if the src/main/webapp dir exists. Similar approach exists in
> different projects (eg. in Spark).
> WIth this patch the web development of the web interfaces are significant
> easier as the result could be checked immediatelly with a running severt
> (without rebuild/restart). I used this patch during the development of the
> Ozone web interfaces.
> As the original behaviour of the resource location has not been change if
> "src/main/webapp" doesn't exist, I think it's quite safe. And the method is
> called only once during the creation of the HttpServer2 there is also no
> change in performance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
