[
https://issues.apache.org/jira/browse/HADOOP-14521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164778#comment-16164778
]
Rushabh S Shah commented on HADOOP-14521:
-----------------------------------------
bq. I'll take the simple route to revert this everywhere, and re-commit after
improvement.
Note that there is nothing to change in this patch.
The 2 jiras which are responsible for reverting this patch are:
1. HADOOP-14445: This is because the initial design was flawed and conf based
and we added another hack (to retry on all servers until it succeeded).
2. HADOOP-14841: We don't understand the actual bug and wanting to add the same
hack (retrying until it succeeds).
Personally after we fix HADOOP-14445, I will suggest to put this patch in even
if HADOOP-14841 is fixed or not.
In our internal repository, we are going to commit this jira and I don't want
to maintain this diff forever.
I am sure we will uncover other bugs (because of flaws in original design)
since we were retrying on all exceptions until it succeeds.
> KMS client needs retry logic
> ----------------------------
>
> Key: HADOOP-14521
> URL: https://issues.apache.org/jira/browse/HADOOP-14521
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Rushabh S Shah
> Assignee: Rushabh S Shah
> Attachments: HADOOP-14521.09.patch,
> HADOOP-14521-branch-2.8.002.patch, HADOOP-14521-branch-2.8.2.patch,
> HADOOP-14521-trunk-10.patch, HDFS-11804-branch-2.8.patch,
> HDFS-11804-trunk-1.patch, HDFS-11804-trunk-2.patch, HDFS-11804-trunk-3.patch,
> HDFS-11804-trunk-4.patch, HDFS-11804-trunk-5.patch, HDFS-11804-trunk-6.patch,
> HDFS-11804-trunk-7.patch, HDFS-11804-trunk-8.patch, HDFS-11804-trunk.patch
>
>
> The kms client appears to have no retry logic – at all. It's completely
> decoupled from the ipc retry logic. This has major impacts if the KMS is
> unreachable for any reason, including but not limited to network connection
> issues, timeouts, the +restart during an upgrade+.
> This has some major ramifications:
> # Jobs may fail to submit, although oozie resubmit logic should mask it
> # Non-oozie launchers may experience higher rates if they do not already have
> retry logic.
> # Tasks reading EZ files will fail, probably be masked by framework reattempts
> # EZ file creation fails after creating a 0-length file – client receives
> EDEK in the create response, then fails when decrypting the EDEK
> # Bulk hadoop fs copies, and maybe distcp, will prematurely fail
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
