[
https://issues.apache.org/jira/browse/HADOOP-14670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168683#comment-16168683
]
Wangda Tan commented on HADOOP-14670:
-------------------------------------
[~aw] / [~chris.douglas],
I just checked changes of this JIRA doesn't relate to issues I saw, I tried to
revert this patch but issue is still the same.
{color:red}It seems the {{set (CMAKE_C_STANDARD)}} doesn't work for the
nodemanager project.
{color}
I hardcoded to change {{set (CMAKE_C_STANDARD 99)}} to {{set (CMAKE_C_STANDARD
90)}} in nodemanager project.
I tried on two different environment:
1) Centos 6, cmake version 3.1.0, gcc 4.4.7
For both 99/90 standard, all fail.
2) OSX v10.12.4, cmake version 3.5.2, cc = "Apple LLVM version 8.1.0
(clang-802.0.42)".
For both 99/90 standard, all succeeded.
At least for the for loop in gpu-module.c is C99 only:
{code}
for (int i = 0; i < n_minor_devices_to_block; i++) {
// ...
}
{code}
Could you share some thoughts?
Thanks,
> Increase minimum cmake version for all platforms
> ------------------------------------------------
>
> Key: HADOOP-14670
> URL: https://issues.apache.org/jira/browse/HADOOP-14670
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: 3.0.0-beta1
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Fix For: 3.0.0-beta1
>
> Attachments: HADOOP-14670.00.patch, HADOOP-14670.01.patch,
> HADOOP-14670.02.patch, HADOOP-14670.03.patch
>
>
> cmake 2.6 is old at this point and I'd be greatly surprised if anyone is
> actually using it or testing against it. It's probably time to upgrade to
> something approaching modern. Plus:
> * Mac OS X already requires 3.0
> * If HADOOP-14667 gets committed, Windows bumps to 3.1
> * There is special handling in at least one CMakeLists.txt for versions less
> than 3.1
> Given the last two points, I'd propose making the minimum 3.1, if not
> something higher due to compiler support for newer compilers across all
> platforms.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
