[
https://issues.apache.org/jira/browse/HADOOP-13917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170593#comment-16170593
]
Sean Busbey commented on HADOOP-13917:
--------------------------------------
{code}
It looks like this will fail on Windows since it's cleaning and rebuilding the
entire source tree and not providing the flags needed to build the native
components. (-Pnative-win is always turned on for Windows since winutils is
required.) That said: it's not the only plugin that has that problem, but it's
worth mentioning. We should probably shove the native code flags (on just
Windows?) into the maven args once and be done with it.
{code}
So best to skip if we're on windows then? I had presumed anything needed would
be in the maven args.
{code}
If I'm reading this correctly, it's going to add about 20 minutes to patch
testing that's... not insignificant. Is the clean actually necessary? Is the
goal to flag if it is broken pre-patch as well? Would this better to run as a
_tests -type plugin?
{code}
I'm not sure if 20 minutes is the norm. If we leave out the clean, then adding
this check shouldn't add more than a few minutes to any build that has already
done an install. It's been helpful in hbase to flag when these things are
broken pre-patch, which is why I left it that way here.
> Ensure nightly builds run the integration tests for the shaded client
> ---------------------------------------------------------------------
>
> Key: HADOOP-13917
> URL: https://issues.apache.org/jira/browse/HADOOP-13917
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, test
> Affects Versions: 3.0.0-alpha2
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Attachments: HADOOP-13917.WIP.0.patch
>
>
> Either QBT or a different jenkins job should run our integration tests,
> specifically the ones added for the shaded client.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
