[ 
https://issues.apache.org/jira/browse/HADOOP-14713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172894#comment-16172894
 ] 

Daniel Templeton commented on HADOOP-14713:
-------------------------------------------

It's a matter of scope.  You don't want one JIRA with changes to 100 files.  In 
those cases it's best to split it up by component or package.  If there are 
only a dozen or so tests that need to be fixed, one JIRA is fine.  There's no 
real rule, though, so use your judgement.  The risk is that if it touches too 
many files, 1) the review will take a while, and then 2) by the time you get it 
reviewed, you'll have to rebase it.

> Audit for durations that should be measured via Time.monotonicNow
> -----------------------------------------------------------------
>
>                 Key: HADOOP-14713
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14713
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Jason Lowe
>              Labels: newbie
>
> Whenever we are measuring a time delta or duration in the same process, the 
> timestamps probably should be using Time.monotonicNow rather than Time.now or 
> System.currentTimeMillis.  The latter two are directly reading the system 
> clock which can move faster or slower than actual time if the system is 
> undergoing a time adjustment (e.g.: adjtime or admin sets a new system time).
> We should go through the code base and identify places where the code is 
> using the system clock but really should be using monotonic time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to