[
https://issues.apache.org/jira/browse/HADOOP-14902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182607#comment-16182607
]
Jason Lowe commented on HADOOP-14902:
-------------------------------------
Thanks for updating the patch! There's a potential NPE if the fc.create throws
and leaves {{out}} null where the finally block will try to close it. The
fc.create call should be moved outside of the try block.
> LoadGenerator#genFile write close timing is incorrectly calculated
> ------------------------------------------------------------------
>
> Key: HADOOP-14902
> URL: https://issues.apache.org/jira/browse/HADOOP-14902
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.4.0
> Reporter: Jason Lowe
> Assignee: Hanisha Koneru
> Attachments: HADOOP-14902.001.patch, HADOOP-14902.002.patch
>
>
> LoadGenerator#genFile's write close timing code looks like the following:
> {code}
> startTime = Time.now();
> executionTime[WRITE_CLOSE] += (Time.now() - startTime);
> {code}
> That code will generate a zero (or near zero) write close timing since it
> isn't actually closing the file in-between timestamp lookups.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
