[
https://issues.apache.org/jira/browse/HADOOP-14788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184303#comment-16184303
]
Ajay Kumar commented on HADOOP-14788:
-------------------------------------
[[email protected]], thanks for review.
bq. And we should make the new exception raised a PathIOException, giving it
the path explicitly. Lets callers get that path back, if they want. Path IOEs
generate their own message, including that path in, so the message passed in
could be tuned.
Sorry this point is not very clear to me. Do you mean we should return
{{PathIOException}} for all other remaining IOEs (i.e those not in if clauses)
or instead of creating instance via reflection we should simply return
PathIOException?
> Credentials readTokenStorageFile to stop wrapping IOEs in IOEs
> --------------------------------------------------------------
>
> Key: HADOOP-14788
> URL: https://issues.apache.org/jira/browse/HADOOP-14788
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.8.1
> Reporter: Steve Loughran
> Assignee: Ajay Kumar
> Priority: Minor
> Attachments: HADOOP-14788.001.patch
>
>
> When {{Credentials readTokenStorageFile}} gets an IOE. it catches & wraps
> with the filename, so losing the exception class information.
> Is this needed. or can it pass everything up?
> If it is needed, well, it's a common pattern: wrapping the exception with the
> path & operation. Maybe it's time to add an IOE version of
> {{NetworkUtils.wrapException()}} which handles the broader set of IOEs
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
