[ 
https://issues.apache.org/jira/browse/HADOOP-12672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189105#comment-16189105
 ] 

Masatake Iwasaki commented on HADOOP-12672:
-------------------------------------------

[~yufeigu] I think using 0 as no timeout is natural because the rpc timeout 
results in java.net.Socket#setSoTimeout which interpret 0 as an infinite 
timeout. The many part of the code seems to use the timeout value 0 as infinite 
timeout. While Client#getTimeout returns -1 implying that ipc.client.ping is 
disabled, it is remains of the past code in which rpc timeout is tightly 
coupled with ipc ping.

I agree to improve documentation to make it clear that the rpc timeout is 
disabled by default (for compatibility reason).


> RPC timeout should not override IPC ping interval
> -------------------------------------------------
>
>                 Key: HADOOP-12672
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12672
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>    Affects Versions: 2.8.0, 2.7.3, 2.6.4
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>             Fix For: 2.8.0, 3.0.0-alpha1
>
>         Attachments: HADOOP-12672.001.patch, HADOOP-12672.002.patch, 
> HADOOP-12672.003.patch, HADOOP-12672.004.patch, HADOOP-12672.005.patch, 
> HADOOP-12672.006.patch
>
>
> Currently if the value of ipc.client.rpc-timeout.ms is greater than 0, the 
> timeout overrides the ipc.ping.interval and client will throw exception 
> instead of sending ping when the interval is passed. RPC timeout should work 
> without effectively disabling IPC ping.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to