[ 
https://issues.apache.org/jira/browse/HADOOP-14217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202791#comment-16202791
 ] 

ASF GitHub Bot commented on HADOOP-14217:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/269#discussion_r144434195
  
    --- Diff: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
 ---
    @@ -214,6 +213,12 @@ public Path(String pathString) throws 
IllegalArgumentException {
         // uri path is the rest of the string -- query & fragment not supported
         String path = pathString.substring(start, pathString.length());
     
    +    // add "./" in front of Linux relative paths so that a path containing
    +    // a colon e.q. "a:b" will not be interpreted as scheme "a".
    +    if (!WINDOWS && !path.isEmpty() && path.charAt(0) != '/') {
    --- End diff --
    
    I refer to the first slash and the first colon in the passed `pathString` 
parameter:
    ```
    int colon = pathString.indexOf(':');
    int slash = pathString.indexOf('/');
    ```
    My understanding is that prepending "./" to the path, ensures that "/" is 
before ":" to avoid interpreting character sequence that `Path` does not 
recognized as scheme to be interpreted as scheme by `URI`. If there is no colon 
or slash is already before a colon, there is no need to add "./".


> Object Storage: support colon in object path
> --------------------------------------------
>
>                 Key: HADOOP-14217
>                 URL: https://issues.apache.org/jira/browse/HADOOP-14217
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, fs/oss
>    Affects Versions: 2.8.1
>            Reporter: Genmao Yu
>            Assignee: Yuliya Feldman
>         Attachments: Colon handling in hadoop Path.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to