[
https://issues.apache.org/jira/browse/HADOOP-14944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Zhuge updated HADOOP-14944:
--------------------------------
Attachment: HADOOP-14944.05.patch
[~xiaochen] Thanks for your patience. This seemingly simple JIRA reveals the
ugliness in testing the singletons.
The patch 04 looks great overall except the new miniClusterMode flag. I think
we can take a different approach shown in patch 05 I just uploaded. Easier for
me to show the code instead of posting review comments. The approach is to
shutdown the JvmMetrics singleton in {{KMSWebServer#stop}}, right before
calling {{DefaultMetricsSystem.shutdown}}. Let me know what you think.
Passed {{mvn test -P\!shelltest -Dtest=TestJvmMetrics,TestKMS,TestKMSWithZK}}.
> Add JvmMetrics to KMS
> ---------------------
>
> Key: HADOOP-14944
> URL: https://issues.apache.org/jira/browse/HADOOP-14944
> Project: Hadoop Common
> Issue Type: Improvement
> Components: kms
> Affects Versions: 2.6.0
> Reporter: Xiao Chen
> Assignee: Xiao Chen
> Attachments: HADOOP-14944.01.patch, HADOOP-14944.02.patch,
> HADOOP-14944.03.patch, HADOOP-14944.04.patch, HADOOP-14944.05.patch,
> HADOOP-14944.branch-2.01.patch
>
>
> Let's make KMS to use {{JvmMetrics}} to report aggregated statistics about
> heap / GC etc.
> This will make statistics monitoring easier, and compatible across the
> tomcat-based (branch-2) KMS and the jetty-based (branch-3) KMS.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
