[
https://issues.apache.org/jira/browse/HADOOP-14594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213256#comment-16213256
]
Steve Loughran commented on HADOOP-14594:
-----------------------------------------
I'm seeing these uncommented tests failing on non-s3guarded runs
{code}
-------------------------------------------------------Running
org.apache.hadoop.fs.s3a.ITestS3AFileOperationCostTests run: 7, Failures: 1,
Errors: 0, Skipped: 0, Time elapsed: 12.012 sec <<< FAILURE! - in
org.apache.hadoop.fs.s3a.ITestS3AFileOperationCosttestFakeDirectoryDeletion(org.apache.hadoop.fs.s3a.ITestS3AFileOperationCost)
Time elapsed: 2.634 sec <<< FAILURE! java.lang.AssertionError: after
mkdir(srcDir): object_delete_requests expected:<1> but was:<2>
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:743)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:555)
at
org.apache.hadoop.fs.s3a.S3ATestUtils$MetricDiff.assertDiffEquals(S3ATestUtils.java:519)
at
org.apache.hadoop.fs.s3a.ITestS3AFileOperationCost.testFakeDirectoryDeletion(ITestS3AFileOperationCost.java:225)
{code}
I think I might revert this as its disabled on s3guard and it doesn't really
gain us much. We care more that the dirs are there than the exact number of
delete requests
> ITestS3AFileOperationCost::testFakeDirectoryDeletion to uncomment metric
> assertions
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-14594
> URL: https://issues.apache.org/jira/browse/HADOOP-14594
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Fix For: 2.9.0, 3.0.0-alpha4
>
> Attachments: HADOOP-14594.000.patch, HADOOP-14594.001.patch
>
>
> Per discussion [HADOOP-14255] and [HADOOP-13222], we can delete the TODO
> comment in tests for metric assertions.
> See the attached patch for more details.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
