[ https://issues.apache.org/jira/browse/HADOOP-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213276#comment-16213276 ]
Steve Loughran commented on HADOOP-14942: ----------------------------------------- LGTM +1 cleanup code is always good to make robust > DistCp#cleanup() should check whether jobFS is null > --------------------------------------------------- > > Key: HADOOP-14942 > URL: https://issues.apache.org/jira/browse/HADOOP-14942 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ted Yu > Assignee: Andras Bokor > Priority: Minor > Fix For: 2.9.0, 3.0.0 > > Attachments: HADOOP-14942.01.patch > > > Over in HBASE-18975, we observed the following: > {code} > 2017-10-10 17:22:53,211 DEBUG [main] mapreduce.MapReduceBackupCopyJob(313): > Doing COPY_TYPE_DISTCP > 2017-10-10 17:22:53,272 DEBUG [main] mapreduce.MapReduceBackupCopyJob(322): > DistCp options: [hdfs://localhost:55247/backupUT/.tmp/backup_1507681285309, > hdfs://localhost:55247/ backupUT] > 2017-10-10 17:22:53,283 ERROR [main] tools.DistCp(167): Exception encountered > java.lang.reflect.InvocationTargetException > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyJob$BackupDistCp.execute(MapReduceBackupCopyJob.java:234) > at org.apache.hadoop.tools.DistCp.run(DistCp.java:153) > at > org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyJob.copy(MapReduceBackupCopyJob.java:331) > at > org.apache.hadoop.hbase.backup.impl.IncrementalTableBackupClient.incrementalCopyHFiles(IncrementalTableBackupClient.java:286) > ... > Caused by: java.lang.NullPointerException > at org.apache.hadoop.tools.DistCp.cleanup(DistCp.java:460) > ... 45 more > {code} > NullPointerException came from second line below: > {code} > if (metaFolder == null) return; > jobFS.delete(metaFolder, true); > {code} > in which case jobFS was null. > A check against null should be added. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org