[
https://issues.apache.org/jira/browse/HADOOP-14929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219399#comment-16219399
]
Arpit Agarwal commented on HADOOP-14929:
----------------------------------------
Hi [~bharatviswa],
The original comment on the decodeComponent function said:
{code}
* The following function behaves exactly the same as netty's
* <code>QueryStringDecoder#decodeComponent</code> except that it
* does not decode the '+' character as space. WebHDFS takes this scheme
* to maintain the backward-compatibility for pre-2.7 releases.
{code}
I assume switching to the netty decoder does not introduce incompatibility
because {{+}} is never expected in the CreateFlag?
> Cleanup usage of decodecomponent and use QueryStringDecoder from netty
> ----------------------------------------------------------------------
>
> Key: HADOOP-14929
> URL: https://issues.apache.org/jira/browse/HADOOP-14929
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Attachments: HADOOP-14929.00.patch, HADOOP-14929.01.patch
>
>
> This is from the review of HADOOP-14910
> There is also other place usage of
> decodeComponent(param(CreateFlagParam.NAME), StandardCharsets.UTF_8);
> In ParameterParser.java Line 147-148:
> String cf = decodeComponent(param(CreateFlagParam.NAME),
> StandardCharsets.UTF_8);
> Use QueryStringDecoder from netty here too and cleanup the decodeComponent.
> Actually this is added for netty issue only.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
