[
https://issues.apache.org/jira/browse/HADOOP-13684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222768#comment-16222768
]
Xiao Chen commented on HADOOP-13684:
------------------------------------
The regression of this commit is because it changed
{code}
if (!NativeCodeLoader.isNativeCodeLoaded() ||
!NativeCodeLoader.buildSupportsSnappy()) {
throw
}
{code}
to
{code}
if (!NativeCodeLoader.buildSupportsSnappy()) {
throw
}
if (!NativeCodeLoader.isNativeCodeLoaded()) {
throw
}
{code}.
So, I was proposing we could fix this in HADOOP-14981 by doing
{code}
if (!NativeCodeLoader.isNativeCodeLoaded()) {
throw
}
if (!NativeCodeLoader.buildSupportsSnappy()) {
throw
}
{code}
which is behaviorally identical to before this commit, but with a different
exception message. This should solve the 'original problem' IMO.
> Snappy may complain Hadoop is built without snappy if libhadoop is not found.
> -----------------------------------------------------------------------------
>
> Key: HADOOP-13684
> URL: https://issues.apache.org/jira/browse/HADOOP-13684
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Wei-Chiu Chuang
> Assignee: Wei-Chiu Chuang
> Priority: Minor
> Labels: supportability
> Fix For: 2.8.0, 3.0.0-alpha2
>
> Attachments: HADOOP-13684.001.patch, HADOOP-13684.002.patch
>
>
> If for some reason libhadoop can not be found/loaded, Snappy complains Hadoop
> is not built with Snappy but it actually is.
> {code:title=SnappyCodec.java}
> public static void checkNativeCodeLoaded() {
> if (!NativeCodeLoader.isNativeCodeLoaded() ||
> !NativeCodeLoader.buildSupportsSnappy()) {
> throw new RuntimeException("native snappy library not available: " +
> "this version of libhadoop was built without " +
> "snappy support.");
> }
> {code}
> This case may happen with MAPREDUCE-6577.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
